Use new usable hosts endpoint #1647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjan
commented
Nov 4, 2024
| case api.EventSettingUpdate: | ||
| log = log.With("gouging", e.GougingSettings != nil, "pinned", e.PinnedSettings != nil, "upload", e.UploadSettings != nil, "ts", e.Timestamp) | ||
| c.handleSettingUpdate(e) | ||
| c.cache.Invalidate(cacheKeyUsableHosts) |
There was a problem hiding this comment.
Took a bit of a shortcut here because we're going to drastically overhaul the cache anway.
…to pj/usable-hosts-cache
peterjan
commented
Nov 12, 2024
…erd into pj/usable-hosts-cache
peterjan
force-pushed
the
pj/usable-hosts-cache
branch
from
acd684e
to
178db62
Compare
ChrisSchinnerl
approved these changes
Nov 14, 2024
| if err != nil && !utils.IsErr(err, api.ErrSlabNotFound) { | ||
| var objects []api.ObjectMetadata | ||
| if res, err := w.bus.Objects(ctx, "", api.ListObjectOptions{SlabEncryptionKey: slab.EncryptionKey}); err != nil { | ||
| w.logger.Errorf("failed to list objects for slab key; %w", err) | ||
| w.logger.Error("failed to list objects for slab key; %v", err) |
There was a problem hiding this comment.
Using Error with %v as a formatting directive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.